[NetKAN] Tolerate Malformed Author URLs from KS/SD #1580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From KSP-CKAN/NetKAN#2980. This PR changes the datatype of KerbalStuff's
website
andsource_code
properties intoString
fromUri
, since we have no guarantee that they're actually well-formedUri
strings. Now when "normalizing" the URIs (renamed the method fromEscape
toNormalize
since we were doing a lot more in it than merely escaping characters) we do a final check to make sure the string is a well formed URI. If it is, we proceed as normal, if it isn't we spit out a warning and returnnull
, preventing it from being added to the metadata (theSafeAdd
extension method will ignorenull
inputs).@politas @plague006 @pjf