Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "X" icon to filter text boxes that clears the control #1883

Merged
merged 9 commits into from
Sep 5, 2016

Conversation

ayan4m1
Copy link
Contributor

@ayan4m1 ayan4m1 commented Sep 2, 2016

This resolves #1018 - icon being used comes from Font Awesome which is under the SIL Open Font License.

@ayan4m1 ayan4m1 added Enhancement New features or functionality GUI Issues affecting the interactive GUI labels Sep 2, 2016
@ayan4m1
Copy link
Contributor Author

ayan4m1 commented Sep 3, 2016

Travis failures are due to resx (i.e. embedded icon/image resource script) not building in Mono-land. Will start looking into it, I likely can't figure this out from VS/Windows.

@ayan4m1 ayan4m1 force-pushed the feature/clear-icon-1018 branch from 289a1cf to 7bbb80a Compare September 3, 2016 16:50
@ayan4m1
Copy link
Contributor Author

ayan4m1 commented Sep 3, 2016

@ayan4m1 ayan4m1 self-assigned this Sep 3, 2016
@ayan4m1 ayan4m1 force-pushed the feature/clear-icon-1018 branch from 7bbb80a to 254ed3d Compare September 4, 2016 17:43
@politas politas merged commit 254ed3d into KSP-CKAN:master Sep 5, 2016
politas added a commit that referenced this pull request Sep 5, 2016
@politas
Copy link
Member

politas commented Sep 5, 2016

Lovely!

@ayan4m1 ayan4m1 deleted the feature/clear-icon-1018 branch September 11, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button to clear filter textbox
3 participants