Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Curse to resources #1897

Merged
merged 2 commits into from
Sep 15, 2016
Merged

Add Curse to resources #1897

merged 2 commits into from
Sep 15, 2016

Conversation

Olympic1
Copy link
Member

Adds the Curse Uri to the "resources" stanza together with curse licenses.

"resources": {
    "curse": "http://kerbal.curseforge.com/projects/220221"
}

@Olympic1 Olympic1 added pull request Spec Issues affecting the spec Netkan Issues affecting the netkan data Schema Issues affecting the schema labels Sep 12, 2016
@politas politas added this to the 1.20.1 milestone Sep 13, 2016
@politas politas self-assigned this Sep 13, 2016
@politas
Copy link
Member

politas commented Sep 13, 2016

Looks good, and can go into the patch release.

@@ -131,7 +131,7 @@ public GUIMod(CkanModule mod, IRegistryQuerier registry, KspVersion current_ksp_

Abstract = mod.@abstract;

// If we have homepage provided use that, otherwise use the spacedock page or the github repo so that users have somewhere to get more info than just the abstract.
// If we have a homepage provided, use that; otherwise use the spacedock page, curse page or the github repo so that users have somewhere to get more info than just the abstract.

Homepage = "N/A";
if (mod.resources != null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have dropped Mono 3.2 compiler tests we can make this one long x ?? y ?? z expression

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't done that yet. That'll be after 1.20.1

Copy link
Contributor

@ayan4m1 ayan4m1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without understanding the meta-kan stuff very well, this looks good in terms of content and improved formatting.

@politas politas merged commit 769a511 into KSP-CKAN:master Sep 15, 2016
politas added a commit that referenced this pull request Sep 15, 2016
Merge pull request #1897 Add Curse to Resources
Add changelog entry for #1893
@Olympic1 Olympic1 deleted the Curse branch September 15, 2016 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Netkan Issues affecting the netkan data Schema Issues affecting the schema Spec Issues affecting the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants