-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Curse to resources #1897
Add Curse to resources #1897
Conversation
Looks good, and can go into the patch release. |
@@ -131,7 +131,7 @@ public GUIMod(CkanModule mod, IRegistryQuerier registry, KspVersion current_ksp_ | |||
|
|||
Abstract = mod.@abstract; | |||
|
|||
// If we have homepage provided use that, otherwise use the spacedock page or the github repo so that users have somewhere to get more info than just the abstract. | |||
// If we have a homepage provided, use that; otherwise use the spacedock page, curse page or the github repo so that users have somewhere to get more info than just the abstract. | |||
|
|||
Homepage = "N/A"; | |||
if (mod.resources != null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have dropped Mono 3.2 compiler tests we can make this one long x ?? y ?? z
expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't done that yet. That'll be after 1.20.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without understanding the meta-kan stuff very well, this looks good in terms of content and improved formatting.
Adds the Curse Uri to the
"resources"
stanza together with curse licenses.