-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend -single-instance fix to 1.9 #3001
Extend -single-instance fix to 1.9 #3001
Conversation
8e67825
to
162a07c
Compare
162a07c
to
db33493
Compare
Thanks for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Want to try merging your own changes to master?
No risk no fun 😁 |
Oh, thanks! Also: And
Rough translation:
We'll have to find yet another workaround for this... |
Well, this is weird. I don't know how I got the Win23Exception to show up earlier, but it's not happening anymore. |
Problem
#2902, which was fixed for KSP 1.8 in #2931, still applies to KSP 1.9 unfortunately:
(Now you know the German translation for a segmentation fault)
Changes
The version range for which we remove the
-single-instance
command has been extended to include 1.9.I created a new helper function which allows to create a
KspVersionRange
from twoKspVersion
objects. The resulting version range extends from the lowest possible version of the first argument to the highest possible version of the second argument.It uses the
KspVersion
->KspVersionRange
logic fromkspversion.ToVersionRange()
.