Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CustomFlags.netkan #1

Merged
merged 1 commit into from
Mar 14, 2023
Merged

add CustomFlags.netkan #1

merged 1 commit into from
Mar 14, 2023

Conversation

warior456
Copy link
Contributor

@warior456 warior456 commented Mar 5, 2023 •
edited by HebaruSan
Loading

@HebaruSan
Copy link
Member

HebaruSan commented Mar 5, 2023 •
edited
Loading

Hi @warior456, thanks for the submission. We're not adding KSP2 mods yet, but we'll come back to this after KSP-CKAN/CKAN#3797 and KSP-CKAN/NetKAN-Infra#282 or KSP-CKAN/NetKAN-Infra#283 are merged.

EDIT: Also KSP-CKAN/CKAN#3811 and KSP-CKAN/xKAN-meta_testing#91, so we can actually validate the metadata.

@HebaruSan HebaruSan closed this Mar 5, 2023
@HebaruSan HebaruSan mentioned this pull request Mar 14, 2023
Merged
@HebaruSan
Copy link
Member

Some of the validation stuff is in place, but it's not yet fully functional. Re-opening this to continue alongside #2.

@HebaruSan HebaruSan reopened this Mar 14, 2023
HebaruSan
HebaruSan approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Looks like this will work fine once KSP-CKAN/NetKAN-Infra#283 is done.

@HebaruSan HebaruSan merged commit 471e60a into KSP-CKAN:main Mar 14, 2023
@HebaruSan HebaruSan mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HebaruSan HebaruSan HebaruSan approved these changes

Assignees
No one assigned
Labels
Mod request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warior456 @HebaruSan