You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an outgrowth of KSP-CKAN/CKAN#2789 (comment). I assume that the initial functionality of the queue-based bot will be identical to NetKAN-bot, so ideas for further improvements should be submitted here for better tracking.
Motivation
See KSP-CKAN/CKAN#2824. We use epochs to coerce author-created versions into a sensible ordering, but this requires a lot of manual intervention and could potentially be automated.
Suggestion
Before submitting a netkan to be inflated, scan the existing versions of that module and compare their versions to find the maximum. Send this in the HighestVersion attribute of the queue
message. Proof of concept code:
This runs slowly because it executes mono and ckan.exe once per version (but it does output the right answer). To make it acceptably fast, we would need to rewrite the version comparison logic in Python:
This is an outgrowth of KSP-CKAN/CKAN#2789 (comment). I assume that the initial functionality of the queue-based bot will be identical to NetKAN-bot, so ideas for further improvements should be submitted here for better tracking.
Motivation
See KSP-CKAN/CKAN#2824. We use epochs to coerce author-created versions into a sensible ordering, but this requires a lot of manual intervention and could potentially be automated.
Suggestion
Before submitting a netkan to be inflated, scan the existing versions of that module and compare their versions to find the maximum. Send this in the
HighestVersion
attribute of the queuemessage. Proof of concept code:
https://gist.github.com/HebaruSan/1fc031cbd97a9a1db2c7bf3c46e9894f
This runs slowly because it executes mono and
ckan.exe
once per version (but it does output the right answer). To make it acceptably fast, we would need to rewrite the version comparison logic in Python:https://github.com/KSP-CKAN/CKAN/blob/14ab1522e410c2bb0860d60b8986f625ec42a78e/Core/Versioning/ModuleVersion.cs#L191-L365
Or we could write a new
ckan.exe max_version a b c d
command, etc.The text was updated successfully, but these errors were encountered: