Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might have to clear cache on RP-1 #8603

Closed
NathanKell opened this issue Jun 28, 2021 · 3 comments
Closed

Might have to clear cache on RP-1 #8603

NathanKell opened this issue Jun 28, 2021 · 3 comments

Comments

@NathanKell
Copy link
Contributor

Sorry, I uploaded a bad zip for the v1.9 release (it had a bare RP-0 folder instead of GameData/RP-0). I removed it and uploaded a zip of a different name with the proper structure in the hope that will make NetKAN index it, but might have to force it to since it's the same tag. Sorry!

@DasSkelett
Copy link
Member

DasSkelett commented Jun 28, 2021

Our bot detects reuploaded zips based on the updated_at tag from the API, and removes the old file from the cache automatically.
However in this case, it won't be in the cache at all, since the inflation of the latest release fails:

Too many .version files located: RP-0/RP-0.version, RP-0/RP-1.version

This is still the case in the reupload, there's a stray RP-0.version with really outdated data in it:

{
   "VERSION" : {
      "PATCH" : 0,
      "BUILD" : "260",
      "MAJOR" : "0",
      "MINOR" : "51"
   },
   "GITHUB" : {
      "REPOSITORY" : "RP-0",
      "USERNAME" : "KSP-RO",
      "ALLOW_PRE_RELEASE" : false
   },
   "NAME" : "Realistic Progression Zero",
   "KSP_VERSION" : {
      "MINOR" : "1",
      "MAJOR" : "1",
      "PATCH" : "3"
   },
   "DOWNLOAD" : "https://github.com/KSP-RO/RP-0/releases",
   "URL" : "https://raw.githubusercontent.com/KSP-RO/RP-0/master/GameData/RP-0/RP-0.version"
}

I suppose that file shouldn't be in there.

@NathanKell
Copy link
Contributor Author

Huh. Looks like I had a local file that was .gitignored and I mistakenly zipped it. Thank you! Reuploaded.

Back in Ancient Times the bot didn't use to be that smart, IIRC, hence my question. But then, back then they were travis jobs I think?

@DasSkelett
Copy link
Member

Back in Ancient Times the bot didn't use to be that smart, IIRC, hence my question.

Indeed, removing stale zips for reuploads has been added in KSP-CKAN/CKAN#2337 for GitHub and KSP-CKAN/CKAN#2859 for SpaceDock, and KSP-CKAN/CKAN#2526 made the bot prune zips of failed inflations, which happened in this case.

Huh. Looks like I had a local file that was .gitignored and I mistakenly zipped it. Thank you! Reuploaded.

Looks good, thanks for fixing it: KSP-CKAN/CKAN-meta@0f581d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants