Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake ZeroMiniAVC dependencies from LGG's mods #9438

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Nov 15, 2022

Background

ZeroMiniAVC is very widely installed because ClickThroughBlocker and ToolbarController "depend" on it (see #7690), and most of @linuxgurugamer's mods depend on one or both of those mods. I used scare quotes because they don't actually need ZeroMiniAVC to function, but rather CKAN's dependency system has been exploited to make this mod artificially more popular because @linuxgurugamer wanted users to have their MiniAVC.dll files deleted because the game broke compatibility with old versions of them at some point.

That artificial popularity has been abused previously to show additional messages that have nothing to do with MiniAVC, annoying users and causing support hassles for other mod authors long after the original problem was solved, see linuxgurugamer/QuickMods#18.

Problems

@linuxgurugamer has announced his intention to make ZeroMiniAVC restart the game at startup if it renames any DLLs:

https://forum.kerbalspaceprogram.com/index.php?/topic/210628-zerominiavc-development-thread-beta-testers-needed/

This is a very disruptive thing to do en masse to users against their will, especially since CKAN users can suppress MiniAVC without this mod if they want to after KSP-CKAN/CKAN#3458.

The reason for this change is that ZeroMiniAVC is a bad idea: deleting (or renaming) DLLs at run-time breaks things. So it's not good to have it as a hard-to-avoid dependency in the CKAN ecosystem.

And what if a user chooses to install a mod with a recent, working MiniAVC, and would prefer to actually see its output? These dependencies break that use case.

Changes

Now ClickThroughBlocker and ToolbarController no longer depend on ZeroMiniAVC. Users will be able to install whatever they want without risk of the game restarting itself on startup. If a user wants ZeroMiniAVC and all the risks, quirks, and complications that entails, they can still choose to install it, but they'll no longer be forced to just because they want one of @linuxgurugamer's other mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant