Remove fake ZeroMiniAVC dependencies from LGG's mods #9438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ZeroMiniAVC
is very widely installed becauseClickThroughBlocker
andToolbarController
"depend" on it (see #7690), and most of @linuxgurugamer's mods depend on one or both of those mods. I used scare quotes because they don't actually needZeroMiniAVC
to function, but rather CKAN's dependency system has been exploited to make this mod artificially more popular because @linuxgurugamer wanted users to have theirMiniAVC.dll
files deleted because the game broke compatibility with old versions of them at some point.That artificial popularity has been abused previously to show additional messages that have nothing to do with MiniAVC, annoying users and causing support hassles for other mod authors long after the original problem was solved, see linuxgurugamer/QuickMods#18.
Problems
@linuxgurugamer has announced his intention to make
ZeroMiniAVC
restart the game at startup if it renames any DLLs:https://forum.kerbalspaceprogram.com/index.php?/topic/210628-zerominiavc-development-thread-beta-testers-needed/
This is a very disruptive thing to do en masse to users against their will, especially since CKAN users can suppress MiniAVC without this mod if they want to after KSP-CKAN/CKAN#3458.
The reason for this change is that ZeroMiniAVC is a bad idea: deleting (or renaming) DLLs at run-time breaks things. So it's not good to have it as a hard-to-avoid dependency in the CKAN ecosystem.
And what if a user chooses to install a mod with a recent, working MiniAVC, and would prefer to actually see its output? These dependencies break that use case.
Changes
Now
ClickThroughBlocker
andToolbarController
no longer depend onZeroMiniAVC
. Users will be able to install whatever they want without risk of the game restarting itself on startup. If a user wantsZeroMiniAVC
and all the risks, quirks, and complications that entails, they can still choose to install it, but they'll no longer be forced to just because they want one of @linuxgurugamer's other mods.