Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kOS unable to lock throttle or steering after undocking #1205

Closed
ozin370 opened this issue Oct 22, 2015 · 6 comments
Closed

kOS unable to lock throttle or steering after undocking #1205

ozin370 opened this issue Oct 22, 2015 · 6 comments
Labels
bug Weird outcome is probably not what the mod programmer expected.

Comments

@ozin370
Copy link

ozin370 commented Oct 22, 2015

Was asked by hvacengi to post this issue as a reminder.

After docking and then undocking without ending a kOS program, the core is left unable to lock throttle or steering. Even ending the program and trying to lock throttle or steering manually does not work, only rebooting the core "fixes" the issue. Something related to the FlightControlManager according to hvacengi.

@ozin370
Copy link
Author

ozin370 commented Oct 22, 2015

from the debug console:

[Log]: kOS: FlightControlManager: ToggleFlyByWire: throttle True
[Error]: no such flybywire parameter throttle

@hvacengi
Copy link
Member

It looks like the issue may be that the parameters are being released in UnbindUnloaded and are not being restored until the cpu boots and calls shared.BindingMgr.Load(). I've modified the code to re-add any missing parameters after the default behavior of updating the vessel data.

@ozin370 I won't have much opportunity to test today, can you download this zip file and test with your code?
https://dl.dropboxusercontent.com/u/19195825/kOS/Debug-issue-1205.zip
(let me know if you're using a custom build, this is based on the current develop branch)

@ozin370
Copy link
Author

ozin370 commented Oct 22, 2015

I just tested it and that seems to have fixed the issue :)

@erendrake erendrake added the duplicate Will close because another PR or issue is the same. (please link to it when using this label) label Oct 22, 2015
@erendrake
Copy link
Member

@ozin370 great news :) we are ramping up for the next release soon

@hvacengi
Copy link
Member

What issue is this a duplicate of? And I haven't sent the PR for this fix yet either. I did a quick compile to see if it fixed it, but the fix isn't part of the develop branch yet as far as I'm aware.

@erendrake
Copy link
Member

just some overeager house cleaning. sorry about that

@erendrake erendrake reopened this Oct 22, 2015
@erendrake erendrake added bug Weird outcome is probably not what the mod programmer expected. and removed duplicate Will close because another PR or issue is the same. (please link to it when using this label) labels Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Weird outcome is probably not what the mod programmer expected.
Projects
None yet
Development

No branches or pull requests

3 participants