Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After GUI merge and Term font merge: use same list picker for both. #1950

Closed
Dunbaratu opened this issue Feb 9, 2017 · 1 comment
Closed
Labels
refactor An infrastructure change that shouldn't change end result.
Milestone

Comments

@Dunbaratu
Copy link
Member

(This is one of several issues that should be addressed after #1878 (GUI toolkit) gets merged into develop but before that code appears in a public realease.) It also needs to wait for #1948 (terminal fonts) to be merged into develop.

Right now, the terminal fonts font chooser in the KOSToolbarWindow uses a custom-made list picker class called ListPIckerDialog. The GUI toolkit also has a list picker widget that kerboscripts can use. In the interest of keeping things consistent, and reducing code repetition, ListPickerDialog should be removed and instead the KOSToolbarWindow should use the GUI toolkit's Popup list dialog that does the same sort of thing. (It should be usable by C# code too just like it's usable by kerboscript code).

@Dunbaratu Dunbaratu added the refactor An infrastructure change that shouldn't change end result. label Feb 9, 2017
@hvacengi hvacengi added this to the v1.1.0 milestone Feb 9, 2017
@Dunbaratu
Copy link
Member Author

I just decided to abandon this idea. After trying to implement this a few times tonight I realized that the way the scripted GUI system works is just too different from what the font picker needs to do for us to use it. Basically, the scripted GUI system doesn't return an IMGUI object I can embed into the middle on a OnGUI call as in "make the popup button and paint it here while I'm in the middle of painting these other IMGUI items."

Instead the constructor returns a non-GUI object that is just the data that the containing GUIWindow "drives". It's the containing GUIWindow that makes it into an IMGUI object. That makes it hard for me to embed it inside something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor An infrastructure change that shouldn't change end result.
Projects
None yet
Development

No branches or pull requests

2 participants