Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part module fields sometimes appear with no name #2518

Closed
RCrockford opened this issue May 20, 2019 · 3 comments · Fixed by #2519
Closed

Part module fields sometimes appear with no name #2518

RCrockford opened this issue May 20, 2019 · 3 comments · Fixed by #2519

Comments

@RCrockford
Copy link
Contributor

In certain cases part module fields can appear with no name if BaseField.guiName has zero length.
In this case it would be better to fall back to BaseField.name; the PAW in KSP appears to do this.

Repro: Latest RO in KSP 1.6.1, engines show a field at the top of the PAW "pressureFed". In kOS this is shown as an unnamed field.

@Dunbaratu
Copy link
Member

Can you define "PAW"? I've never heard the term. From the context of your sentences I'm guessing it might be the menu you get when you right-click a part.

@RCrockford
Copy link
Contributor Author

Sorry yes. Part Action Window, i.e. the right click context menu for a part.

@RCrockford
Copy link
Contributor Author

I've attached a screenshot showing the issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants