Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of startup message about terminal fonts #2606

Closed
Dunbaratu opened this issue Aug 28, 2019 · 1 comment · Fixed by #2629
Closed

Get rid of startup message about terminal fonts #2606

Dunbaratu opened this issue Aug 28, 2019 · 1 comment · Fixed by #2629
Assignees
Labels
bug Weird outcome is probably not what the mod programmer expected.

Comments

@Dunbaratu
Copy link
Member

Dunbaratu commented Aug 28, 2019

There's something wrong with the startup dialog box that describes the terminal font, but it's hard to trace why it's happening because it might be an interaction with other mods. The description is here:

https://forum.kerbalspaceprogram.com/index.php?/topic/165628-173-kos-v1190-kos-scriptable-autopilot-system/&do=findComment&comment=3661594

But in reality it doesn't matter how to fix it, because that dialog box doesn't need to exist anymore. The proper solution should be to just get rid of it entirely. The warning that says to go open the panel and pick a font should be replaced with just silently accepting the default and setting it as if it was the "user's choice". If the player doesn't see that message, that's not the end of the world. They just play with the default font kOS picked and don't know they could go change it on the toolbar dialog box, but not knowing that won't ruin any gameplay.

The original reason for the dialog was to inform people of the transition from the built-in bitmap letter images kOS shipped with to a system font (mostly so Unicode glyphs could be supported without me having to draw the bitmap images of hundreds of different multinational alphabets by hand). But that change was years ago. The box doesn't need to exist anymore.

@Dunbaratu Dunbaratu added the bug Weird outcome is probably not what the mod programmer expected. label Aug 28, 2019
@Dunbaratu Dunbaratu self-assigned this Aug 28, 2019
@ThunderousEcho
Copy link
Contributor

I fixed this on my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Weird outcome is probably not what the mod programmer expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants