Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parts which are both engines and rcs may be missing suffixes #2808

Closed
RCrockford opened this issue Nov 17, 2020 · 3 comments · Fixed by #2809
Closed

Parts which are both engines and rcs may be missing suffixes #2808

RCrockford opened this issue Nov 17, 2020 · 3 comments · Fixed by #2809

Comments

@RCrockford
Copy link
Contributor

I have a part which is both an engine and RCS, it currently gets the RCS suffixes rather than the engine suffixes, but shows up in list engines which makes for some rather awkward or crashy scripts.

Due to the way the PartValue classes are set up, it seems we can't have both, so I think prioritising engines over RCS will generally cause fewer issues.

@mgalyean
Copy link

mgalyean commented Nov 17, 2020

Does kOS echo the multiple inheritance of C#? Could these parts inherit both the engine and (forthcoming) rcs suffixes in theory?

@Dunbaratu
Copy link
Member

@mgalyean C# doesn't have multiple inheritance. The way KSP achieves something similar to multiple inheritance (if, say, a part is two kinds of part at once) is to say that a Part contains two kinds of PartModule rather than saying it is two kinds of Part.

@mgalyean
Copy link

Oh yeah, I was thinking of how interfaces are used to fake it. nevermind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants