Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in documentation in PR #2810 related to new suffix #2812

Closed
nuggreat opened this issue Nov 18, 2020 · 0 comments · Fixed by #2813
Closed

Mistake in documentation in PR #2810 related to new suffix #2812

nuggreat opened this issue Nov 18, 2020 · 0 comments · Fixed by #2813

Comments

@nuggreat
Copy link

The new suffix in for PIDloops :EPSILON is described twice, lines 297-321 and 330-342 I assume the second shorter entry is the unintended one.

Also of note down at the bottom of the file the "PIDLoop Update Derivation" which is a kerboScript translation of the C# code that kOS uses for it's PIDloops was not updated to include where exactly the :EPSILON suffix is applied in the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant