You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dunbaratu opened this issue
Mar 25, 2021
· 2 comments
Labels
bugWeird outcome is probably not what the mod programmer expected.duplicateWill close because another PR or issue is the same. (please link to it when using this label)
I was noticing my landing script thought my vessel was over 18 meters tall, when clearly it was only about 3 or 4 meters high.
Diagnosing this, it turns out that engines return wrong bounds when the Waterfall mod is installed. It seems to be that the exhaust plume is being counted as part of the engine's dimensions (even when the throttle is zero so the engine isn't firing).
To reproduce:
Have these two mods installed: Waterfall, and Stock Waterfall Configs.
Make a ship that uses a Terrier engine (may happen with other engines too, but this is the one I noticed it with).
for p in ship:parts { print "bounds for " + p + " is " + p:bounds. }
Note the :RELMIN for the Terrier engine part has a negative Z of about 18.1 meters.
To fix this we should probably have some better logic within bounds calculations to know which components are "not physical" and therefore should not count. Something that's purely visual with no colliders probably shouldn't count.
The text was updated successfully, but these errors were encountered:
Dunbaratu
added
the
bug
Weird outcome is probably not what the mod programmer expected.
label
Mar 25, 2021
Some of those meshes will be visual-only (and will be unnecessarily detailed with more vertices than the object "physically" has in its collider).
It should probably be iterating over just the colliders, not all the meshes, using this:
bugWeird outcome is probably not what the mod programmer expected.duplicateWill close because another PR or issue is the same. (please link to it when using this label)
I was noticing my landing script thought my vessel was over 18 meters tall, when clearly it was only about 3 or 4 meters high.
Diagnosing this, it turns out that engines return wrong bounds when the Waterfall mod is installed. It seems to be that the exhaust plume is being counted as part of the engine's dimensions (even when the throttle is zero so the engine isn't firing).
To reproduce:
for p in ship:parts { print "bounds for " + p + " is " + p:bounds. }
:RELMIN
for the Terrier engine part has a negative Z of about 18.1 meters.To fix this we should probably have some better logic within bounds calculations to know which components are "not physical" and therefore should not count. Something that's purely visual with no colliders probably shouldn't count.
The text was updated successfully, but these errors were encountered: