Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another RP-1 issue: RP-1 suppresses ship:control:fore when manual RCS fore works. #2970

Closed
Dunbaratu opened this issue Jun 16, 2021 · 4 comments · Fixed by #2971
Closed

Another RP-1 issue: RP-1 suppresses ship:control:fore when manual RCS fore works. #2970

Dunbaratu opened this issue Jun 16, 2021 · 4 comments · Fixed by #2971
Labels
bug Weird outcome is probably not what the mod programmer expected.

Comments

@Dunbaratu
Copy link
Member

Arrrgh. When you don't have sufficient avionics, RP-1 allows pilot-input manual RCS fore and aft axis to still work (so you can fire an ullage-needing engine on a spin-stabalized probe), but RP-1 is suppressing kOS's set ship:control:fore to xxx. - only allowing actual manual keyboard or joystick input to fire RCS fore and aft. Mechjeb's annoying "RCS responds to throttle when main engines not active" is the supposed way around it but that's not right for using some other scripting system.

Thus I can't ullage my engine for ignition in my spin-stabalized first lunar orbit probe.

ship:control:fore is a get-only field that can't be set, and there is no ship:control:foretrim, and there is no ship:control:pilotfore to set.

@Dunbaratu Dunbaratu added the bug Weird outcome is probably not what the mod programmer expected. label Jun 16, 2021
@RCrockford
Copy link
Contributor

I'm thinking we need a better approach to this whereby kOS reads the control locks and only excludes those that are locked.

@Dunbaratu
Copy link
Member Author

Is kOS the one causing the lockout here though?

@RCrockford
Copy link
Contributor

RCrockford commented Jun 16, 2021

It is, yes. In the top of kOSVesselModule.UpdateAutoilot.

If any RP-1 control lock is set, kOS completely disables control.

@nuggreat
Copy link

yes this is done by kOS #2546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Weird outcome is probably not what the mod programmer expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants