Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mars Biomes #163

Closed
ZBok opened this issue Feb 27, 2019 · 11 comments
Closed

Mars Biomes #163

ZBok opened this issue Feb 27, 2019 · 11 comments

Comments

@ZBok
Copy link

ZBok commented Feb 27, 2019

I think the Olympus Mons biome is incorrectly placed. The surface map and biome map seem to be oriented correctly and overlap nicely, but the Olympus Mons biome can be found at several different locations around the planet, similar to Midlands/Lowlands/Highlands.

The actual Olympus Mons location does show the Olympus Mons biome.

@PhineasFreak
Copy link

Did you validate that via the in-game cheat option or just by luck? Because it is known that biome maps can be buggy at times (in stock KSP you can find Tundra just to the east of KSC).

@ZBok
Copy link
Author

ZBok commented Feb 27, 2019

Hmm I used the SCANsat biome map to check as well as the biome map, it's not small isolated areas like Tundra near KSC, more like really large biome sized areas. I didn't land anywhere to check, though another guy user on reddit mentioned a similar problem yesterday, same Olympus Mons biome just nowhere near the mountain.

@jonassm
Copy link

jonassm commented Feb 27, 2019

Im said guy on reddit! I noticed while doing a fly by(inclined aswell) of Mars in RP-1, that the Olympus Mons biome felt like it was everywhere. (Was in said biome for over 24 hours). Also saw Tyler Raiz who does youtube videos on RO/RP1 having the same thing

@ZBok
Copy link
Author

ZBok commented Feb 28, 2019

Hiya said reddit guy! Is your name actually Jonas?

@PhineasFreak
Copy link

If the Olympus Mons biome (colored in bright blue) exists in other places then you will have to open the Mars biome texture and hunt down any other sections (or even single pixels) that have the same color code.

@leudaimon
Copy link

Could there be a name switch in the config?

@PhineasFreak
Copy link

Does not look like it: https://github.com/KSP-RO/RealSolarSystem/blob/master/GameData/RealSolarSystem/RSSKopernicus/Mars/Mars.cfg#L45-L107

And the config color value for the Olympus Mons biome (0.071, 0, 1) translates exactly to the color that the biome map uses (18, 0, 255).

I also combed the entire texture pixel by pixel to see if the color repeats somewhere else but no other biome uses the same color code. Maybe KSP gets confused by the other similar colors (cyan, bark blue, magenta, purple)? Should not though...

@jonassm
Copy link

jonassm commented Mar 1, 2019

I sent some probes to Mars today so i got some anecdotal data, which is very reliable! /s (seriously though, prefacing by saying these are not very scientific tests)

I noticed that the Olympus Mons biome might feel like a biome the game just uses when it doesn't know what else to do. Specifically, when i was over Vallas Marineras, and i was going to Midlands, there was about 2 seconds where the game went to Olympus Mons and then Midlands. This was not even only one specific spot, it happened multipile times.

TL;DR game might use olympus mons as a "default" biome when its confused

@pap1723
Copy link

pap1723 commented Mar 29, 2019

I noticed something similar when I made biome maps for the Moon and Earth a long time ago. I found that there are safe colors to use. What happens is when KSP gets confused, it will default to the first biome in the list. In this case, that is Olympus Mons. I will take a look at seeing if I can find my safe colors and poke at this.

@PhineasFreak
Copy link

Worst case scenario: make "lowlands" the default (fallback) biome.

@RCrockford
Copy link

This should be addressed by #195

@DRVeyl DRVeyl closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants