Fix bug where vessels can remain in situation Splashed. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it can never become unsplashed). Also fixes splashed overriding prelaunch.
…e regardless of stage)
|
This has now been tested in the RO discord by users who did have the bug (and by me, though I could never repro the bug >.> but at least it doesn't hurt anything for me) and seems to work fine. |
gotmachine
added a commit
that referenced
this pull request
Jun 25, 2022
- New KSP bugfix : [StickySplashedFixer](#44) (@NathanKell) - New modding bugfix : [DepartmentHeadImage](#47) (@NathanKell) - PersistentIConfigNode patch : added `Guid` serialization support to `CreateObjectFromConfig()`, `LoadObjectFromConfig()` and `CreateConfigFromObject()` methods (@NathanKell).
gotmachine
added a commit
that referenced
this pull request
Jan 30, 2023
- New KSP bugfix : [StickySplashedFixer](#44) (@NathanKell) - New modding bugfix : [DepartmentHeadImage](#47) (@NathanKell) - PersistentIConfigNode patch : added `Guid` serialization support to `CreateObjectFromConfig()`, `LoadObjectFromConfig()` and `CreateConfigFromObject()` methods (@NathanKell).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
Note this all is slightly confusing because there is both a vessel state (SPLASHED, PRELAUNCH, FLYING, etc) and the bool vessel.Splashed (like vessel.Landed) which says whether any parts are splashed.