-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: reduce log spam #18
Comments
It also logs each time it fails due to shaders not being found, which currently happens a fair bit if someone has a mod using Resurfaced without Resurfaced installed. This particular case might be better taken care of with MM conditional patching instead though, as you probably want errors to still show in the log for actual troubleshooting? So for eg instead of what BDB currently does (just adding the Afaik, it was set up to only have |
Yeah, emitting an error when something goes wrong is fine; but Shabby is currently emitting log messages for every single successful replacement too. |
yup, not worried about performance when something is broken anyways It should be faster now, not sure how I would measure this for it to be anything more than statistical noise |
Shabby currently emits a log line every time it does a shader replacement. We should make those conditionally compiled for performance.
The text was updated successfully, but these errors were encountered: