Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Resolve for Secrets Manager failing #141

Open
neoghostz opened this issue Feb 25, 2019 · 2 comments
Open

Resolve for Secrets Manager failing #141

neoghostz opened this issue Feb 25, 2019 · 2 comments

Comments

@neoghostz
Copy link

Describe the bug
Kombustion fails on inspection of the resolve key word.
Suspect it would also fail on Params Store as well

To Reproduce
Throw the following into and RDS/RedShift properties definition:

      MasterUsername: !Join ['', ['{{resolve:secretsmanager:', !Ref Secret, ':SecretString:username}}' ]]
      MasterUserPassword: !Join ['', ['{{resolve:secretsmanager:', !Ref Secret, ':SecretString:password}}' ]]

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

kombustion upsert ./redshift.yaml --stack-name DataLake-DEV-RedShift --read-parameters ./params.json --region=ap-southeast-2 -i
➜  Generate Default Outputs: [false]
✖  Error: Failed to execute the template
☞  Resolution: File: ./redshift.yaml
template: cfn:123: function "resolve" not defined
✖  Fatal: template: cfn:123: function "resolve" not defined
☞  Resolution: An unknown error occured, please subbmit an issue
∞  More info: https://github.com/KablamoOSS/kombustion/issues/new?template=bug_report.md

Desktop (please complete the following information):
Linux AMD 64 build of v0.5.1

Additional context
Sounds like more custom logic to handle :)

@iann0036
Copy link
Member

Interesting. As a workaround, will this work?

MasterUsername: !Sub "{{resolve:secretsmanager:${Secret}:SecretString:username}}" MasterUserPassword: !Sub "{{resolve:secretsmanager:${Secret}:SecretString:password}}"

@neoghostz
Copy link
Author

Good pickup but nope.
Still failing:

➜  Generate Default Outputs: [false]
✖  Error: Failed to execute the template
☞  Resolution: File: ./redshift.yaml
template: cfn:134: function "resolve" not defined
✖  Fatal: template: cfn:134: function "resolve" not defined
☞  Resolution: An unknown error occured, please subbmit an issue
∞  More info: https://github.com/KablamoOSS/kombustion/issues/new?template=bug_report.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants