Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selene fix #279

Open
Milo123459 opened this issue Jul 27, 2021 · 3 comments · May be fixed by #561
Open

Selene fix #279

Milo123459 opened this issue Jul 27, 2021 · 3 comments · May be fixed by #561
Labels
A-bin Area: selene, the program C-enhancement Category: Feature request or improvement E-hard Call for participation: Experience needed to fix: Hard / a lot

Comments

@Milo123459
Copy link

Something like selene fix to automatically apply fixes. Would be cool to have a command in VSCode to do this.
@Kampfkarren
Copy link
Owner

I'm surprised I haven't already made an issue for this, but yes--fixers are very possible and something I want to add at some point.

@Kampfkarren Kampfkarren added A-bin Area: selene, the program C-enhancement Category: Feature request or improvement E-hard Call for participation: Experience needed to fix: Hard / a lot labels Jul 27, 2021
@Milo123459
Copy link
Author

Great, can't wait. I might be able to contribute.

@Kampfkarren
Copy link
Owner

One of the big qualms with this is styling, I wonder if just attempting to match indentation levels is good enough, and hoping people use something like StyLua for everything else. cargo fix is literally just text swaps, and I know I've seen cargo fix outputs that cargo fmt better, so I bet they're taking the same route.

@chriscerie chriscerie linked a pull request Oct 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-bin Area: selene, the program C-enhancement Category: Feature request or improvement E-hard Call for participation: Experience needed to fix: Hard / a lot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fixers chriscerie/selene
2 participants
@Kampfkarren @Milo123459