Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Investigate image size increases from 23.0 to 23.1 for quarkus-full-microprofile #217

Closed
jerboaa opened this issue Oct 12, 2023 · 2 comments
Assignees

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 12, 2023

The 23.1 release triggered some size increase checks. Here is one failure with quarkus 3.5.0.CR1:

org.opentest4j.AssertionFailedError: 

Application QUARKUS_FULL_MICROPROFILE in mode none executable size  is 76624 kB, which is over 73500 kB threshold by 4%.
 ==> expected: <true> but was: <false>
	at org.graalvm.tests.integration.RuntimesSmokeTest.testRuntime(RuntimesSmokeTest.java:162)
	at org.graalvm.tests.integration.RuntimesSmokeTest.quarkusFullMicroProfile(RuntimesSmokeTest.java:192)

The comparison between 23.0 and 23.1 isn't an apples to apples comparison as 23.0 is JDK 17 based. 23.1 is JDK 21 based. Either way, we need to investigate in order to ensure this isn't unintentional.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Oct 12, 2023

@zakkak You've looked into this recently for 23.0, so assigning to you for now.

@zakkak
Copy link
Collaborator

zakkak commented Nov 7, 2023

The analysis is complete and documented in quarkusio/quarkusio.github.io#1827

TLDR:

According to our analysis the binary size increase is attributed to two distinct changes, both of which are necessary for getting more accurate profiles when using the async-profiler.

If you think that this kind of info should only be included when the user opts-in, please provide your feedback in this discussion.

@zakkak zakkak closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants