Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension API #176

Merged
merged 7 commits into from
Jul 22, 2023
Merged

Add extension API #176

merged 7 commits into from
Jul 22, 2023

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Jul 20, 2023 •
edited
Loading

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

  • Remove unused remove from replace
  • Add skipWarning to replace, remove
  • Add view
  • Export background commands and file operations to API
  • Add tests

Release Notes

Extension developers can now access the background API for this extension, refer to API for details.

@Katsute Katsute self-assigned this Jul 20, 2023
@Katsute Katsute linked an issue Jul 20, 2023 that may be closed by this pull request
Adaptive image selection #175
Closed
@Katsute
Copy link
Member Author

Katsute commented Jul 20, 2023

https://code.visualstudio.com/api/references/vscode-api#extensions

https://code.visualstudio.com/api/references/extension-manifest#:~:text=extensionDependencies

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 20, 2023
View reviewed changes
src/extension.ts Fixed Show fixed Hide fixed
@Katsute
Copy link
Member Author

Katsute commented Jul 22, 2023

todo: README

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2023
View reviewed changes
test/test.js Dismissed Show dismissed Hide dismissed
test/test.js Dismissed Show dismissed Hide dismissed
test/test.js Dismissed Show dismissed Hide dismissed
test/test.js Dismissed Show dismissed Hide dismissed
test/test.js Dismissed Show dismissed Hide dismissed
@Katsute Katsute marked this pull request as ready for review July 22, 2023 19:28
@Katsute

This comment has been minimized.

Sign in to view
ghost
ghost approved these changes Jul 22, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute merged commit 872cf44 into main Jul 22, 2023
8 checks passed
@Katsute Katsute deleted the api@a880f17 branch July 22, 2023 20:25
@ghost ghost locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive image selection
1 participant
@Katsute