Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VSCode product icon escape on file and delete menus #200

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Aug 27, 2023

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

  • Fix incorrect ${...} escape on file and delete menus (should be $(...))

@Katsute Katsute added the bug label Aug 27, 2023
@Katsute Katsute self-assigned this Aug 27, 2023
@Katsute Katsute changed the title Fix ${...} escape on file and delete menu Fix vscode product icon escape on file and delete menu Aug 27, 2023
@Katsute Katsute changed the title Fix vscode product icon escape on file and delete menu Fix vscode product icon escape on file and delete menus Aug 27, 2023
@Katsute

This comment has been minimized.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute merged commit 22592ac into main Aug 27, 2023
8 checks passed
@Katsute Katsute deleted the $@0e11349 branch August 27, 2023 17:12
@ghost ghost locked and limited conversation to collaborators Aug 27, 2023
@Katsute Katsute changed the title Fix vscode product icon escape on file and delete menus Fix VSCode product icon escape on file and delete menus Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant