Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal optimizations #244

Merged
merged 15 commits into from
Nov 29, 2023
Merged

Internal optimizations #244

merged 15 commits into from
Nov 29, 2023

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Nov 10, 2023

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

  • refactor entire codebase
  • hide '... seconds' from detail if 0
  • remove unnecessary reload on sudo activation backup
  • fix sudo on windows

Specific optimizations:

  • cp command
  • separate code injection to own file
  • separate css to own file
  • optimize injection minify
  • condense command registry to extension file
  • condense and optimize file menu

Required Tests

  • cp
  • sudo init (skipped)
  • sudo write
  • missing files (skipped)
  • changelog & help
  • statusbar
  • commands
  • api
  • settings
    • alignment
    • blur
    • opacity
    • repeat
    • size
    • transition
    • no change
  • env
  • vscode icon escape
  • css escape
  • file add
  • file remove
  • duplicate file

Release Notes

  • Remove unnecessary reload on sudo init
  • Fix sudo potentially failing on Windows

@Katsute Katsute self-assigned this Nov 10, 2023
src/extension/config.ts Fixed Show fixed Hide fixed
@Katsute Katsute marked this pull request as ready for review November 12, 2023 19:15
@Katsute Katsute changed the title Extension refactoring Internal optimizations Nov 12, 2023
@Katsute

This comment has been minimized.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 9e47562 Nov 29, 2023
14 checks passed
@Katsute Katsute deleted the refactor@1fee8a9 branch November 29, 2023 17:12
@ghost ghost locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant