Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VSCode 1.72 #45

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Fix VSCode 1.72 #45

merged 4 commits into from
Oct 7, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Oct 7, 2022

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

Release Notes

Installing backgrounds using this extension now causes VSCode to warn about the installation being corrupt 😭. Select Don't Show Again to suppress this message.

corrupt

@Katsute Katsute self-assigned this Oct 7, 2022
@Katsute
Copy link
Member Author

Katsute commented Oct 7, 2022

Backgrounds don't update after some uninstalls, issue is definitely caused by vscode; our promises are working correctly.

@Katsute
Copy link
Member Author

Katsute commented Oct 7, 2022

Issue only occurs if you uninstall before VSCode fully loads, won't fix.

@Katsute Katsute marked this pull request as ready for review October 7, 2022 21:14
@Katsute
Copy link
Member Author

Katsute commented Oct 7, 2022

@mashiro-san approve this pull request

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit 414201b into main Oct 7, 2022
@Katsute Katsute deleted the vs-1.72 branch October 7, 2022 21:21
@ghost ghost locked and limited conversation to collaborators Oct 7, 2022
@Katsute Katsute added this to the M2 milestone Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working in VSCode 1.72
1 participant