Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render content above backgrounds #57

Merged
merged 7 commits into from
Nov 11, 2022
Merged

Render content above backgrounds #57

merged 7 commits into from
Nov 11, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Nov 5, 2022 •
edited
Loading

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

  • Remove z-index so background renders below content
  • Change body::before to body > div[role=application] > div.monaco-grid-view::after

Release Notes

Add new option background.renderContentAboveBackground to render content above backgrounds

@Katsute Katsute added the bug label Nov 5, 2022
@Katsute Katsute self-assigned this Nov 5, 2022
@Katsute Katsute linked an issue Nov 5, 2022 that may be closed by this pull request
Disable backgrounds for editor subwindow on certain filetypes #55
Closed
@Katsute Katsute marked this pull request as draft November 6, 2022 01:53
@Katsute
Copy link
Member Author

Katsute commented Nov 6, 2022

z-index can be dropped for ::after, doesn't work for ::before

  • Markdown preview background is hidden by this change
  • Full screen background doesn't work because of ::before

@Katsute Katsute marked this pull request as ready for review November 7, 2022 02:30
@Katsute Katsute changed the title Render background under iframes Render backgrounds under iframes Nov 7, 2022
@Katsute
Copy link
Member Author

Katsute commented Nov 7, 2022

Potentially breaking change, make togglable?

@Katsute Katsute changed the title Render backgrounds under iframes Render content above backgrounds Nov 8, 2022
@Katsute

This comment has been minimized.

Sign in to view
@Katsute

This comment has been minimized.

Sign in to view
ghost
ghost previously approved these changes Nov 9, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute

This comment has been minimized.

Sign in to view
ghost
ghost approved these changes Nov 11, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit 9f61892 into main Nov 11, 2022
@Katsute Katsute deleted the fix-background-layering@45311d3 branch November 11, 2022 03:16
@ghost ghost locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable backgrounds for editor subwindow on certain filetypes
1 participant
@Katsute