Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install notification sometimes not installing backgrounds #66

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix install notification sometimes not installing backgrounds #66

merged 1 commit into from
Nov 23, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Nov 23, 2022 •
edited
Loading

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

Release Notes

  • Fix rare bug where install notification would be sent before settings actually update
  • Fix multiple install notifications when selecting multiple files at once

@Katsute Katsute added the bug label Nov 23, 2022
@Katsute Katsute self-assigned this Nov 23, 2022
@Katsute

This comment has been minimized.

Sign in to view
ghost
ghost approved these changes Nov 23, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit 39f7bc0 into main Nov 23, 2022
@Katsute Katsute deleted the fix-notify@5ef4a45 branch November 23, 2022 03:17
@ghost ghost locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Background sometimes does not install Blur makes background image disappear or won't work
1 participant
@Katsute