Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "scrollback buffer" limit? #12

Open
jpsamaroo opened this issue Nov 21, 2017 · 2 comments
Open

Implement "scrollback buffer" limit? #12

jpsamaroo opened this issue Nov 21, 2017 · 2 comments

Comments

@jpsamaroo
Copy link
Contributor

Currently, ScreenEmulator will accumulate lines in its buffer continuously, without limit. If used for extended processing of terminal input, eventually ScreenEmulator's buffer will use up all available memory. Would it be feasible/acceptable to add a limit to the number of lines stored (by default set to either infinity or some reasonable value)?

@Keno
Copy link
Owner

Keno commented Nov 22, 2017

Sure, that seems reasonable. What's your use case?

@jpsamaroo
Copy link
Contributor Author

jpsamaroo commented Nov 23, 2017

I'm developing a neural network package which will use VT100.jl to parse output from terminal programs and convert it into a representation which can be fed into a special convolutional layer (even if ScreenEmulator doesn't internally use a dense matrix of Cells, it's easy enough to make work). I intend for this to run for extended periods of time (possibly continuously), so having ScreenEmulator accumulate everything it reads makes this infeasible.

I'm of course totally fine with not using VT100.jl for this if that's not the intended use case, and I can make it work just as well some other way. I've just found it to be a really convenient package for what I'm trying to accomplish 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants