Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add \i and \j for text mode #1029

Merged
merged 1 commit into from
Dec 22, 2017
Merged

add \i and \j for text mode #1029

merged 1 commit into from
Dec 22, 2017

Conversation

kevinbarabash
Copy link
Member

screen shot 2017-12-22 at 11 31 00 am

ry-randall
ry-randall reviewed Dec 22, 2017
View reviewed changes
Copy link
Member

@ry-randall ry-randall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a test here?

edemaine
edemaine approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as-is. I guess I'll add Unicode support for these too in #992 (like I did for \imath and \jmath).

@kevinbarabash
Copy link
Member Author

@rrandallcainc I added a test to verify that \\text{\\i\\j} parses. A screenshot test is probably overkill for this as there a lots of symbols we don't have screenshot tests for.

ry-randall
ry-randall approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@ry-randall ry-randall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edemaine edemaine merged commit 2b2cf73 into master Dec 22, 2017
@kevinbarabash kevinbarabash deleted the dotless_text_i_j branch December 29, 2017 17:09
@edemaine edemaine mentioned this pull request Jan 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-randall ry-randall ry-randall approved these changes

@edemaine edemaine edemaine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinbarabash @edemaine @ry-randall