-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for \mathring #1125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix KaTeX#1124. \mathring is the math-mode equivalent to the \r accent. Support follows from a rather trivial symbol aliasing, plus (for Unicode support) listing it in `unicodeAccents.js`.
kevinbarabash
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -13,6 +13,6 @@ module.exports = { | |||
'\u030c': {text: '\\v', math: '\\check'}, | |||
'\u0302': {text: '\\^', math: '\\hat'}, | |||
'\u0307': {text: '\\.', math: '\\dot'}, | |||
'\u030a': {text: '\\r'}, | |||
'\u030a': {text: '\\r', math: '\\mathring'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
kevinbarabash
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edemaine
added a commit
to edemaine/KaTeX
that referenced
this pull request
Feb 12, 2018
* Fix double handling of ð (math maps to \eth, not special Unicode character) * Remove Åå special math handling, thanks to KaTeX#1125
edemaine
added a commit
to edemaine/KaTeX
that referenced
this pull request
Feb 13, 2018
* Fix double handling of ð (math maps to \eth, not special Unicode character) * Remove Åå special math handling, thanks to KaTeX#1125
kevinbarabash
pushed a commit
that referenced
this pull request
Feb 14, 2018
* Fix double handling of ð (math maps to \eth, not special Unicode character) * Remove Åå special math handling, thanks to #1125
kevinbarabash
pushed a commit
that referenced
this pull request
Feb 20, 2018
* unicodeTextInMathMode setting * When `unicodeTextInMathMode` is `true`, accented letters from `unicodeSymbols.js`, and CJK and other supported languages, get added support in math mode (as requested in #895). * When `unicodeTextInMathMode` is `false, all of these stop working in math mode, and are only supported in text mode (matching XeTeX behavior). Note that this is a backwards incompatibility with some 0.9.0 alpha/betas. * Fix handling of Unicode characters ð, Å, å * Fix double handling of ð (math maps to \eth, not special Unicode character) * Remove Åå special math handling, thanks to #1125 * Forbid extraLatin when unicodeTextInMathMode is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1124.
\mathring
is the math-mode equivalent to the\r
accent (thanks to @akalin for pointing it out!).Support follows from a rather trivial symbol aliasing, plus (for Unicode support) listing it in
unicodeAccents.js
.Screenshot of
shows that skew correction is fine, except somehow for
\textit
(as reported in #1099):