Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for \mathring #1125

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Add support for \mathring #1125

merged 1 commit into from
Feb 1, 2018

Conversation

edemaine
Copy link
Member

@edemaine edemaine commented Feb 1, 2018

Fix #1124. \mathring is the math-mode equivalent to the \r accent (thanks to @akalin for pointing it out!).

Support follows from a rather trivial symbol aliasing, plus (for Unicode support) listing it in unicodeAccents.js.

Screenshot of

\mathring A\mathring B\textit{\r A\r B}\text{\r A\r B}

shows that skew correction is fine, except somehow for \textit (as reported in #1099):
image

Fix KaTeX#1124. \mathring is the math-mode equivalent to the \r accent.
Support follows from a rather trivial symbol aliasing,
plus (for Unicode support) listing it in `unicodeAccents.js`.
Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -13,6 +13,6 @@ module.exports = {
'\u030c': {text: '\\v', math: '\\check'},
'\u0302': {text: '\\^', math: '\\hat'},
'\u0307': {text: '\\.', math: '\\dot'},
'\u030a': {text: '\\r'},
'\u030a': {text: '\\r', math: '\\mathring'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbarabash kevinbarabash merged commit 684df05 into KaTeX:master Feb 1, 2018
edemaine added a commit to edemaine/KaTeX that referenced this pull request Feb 12, 2018
* Fix double handling of ð (math maps to \eth, not special Unicode character)
* Remove Åå special math handling, thanks to KaTeX#1125
edemaine added a commit to edemaine/KaTeX that referenced this pull request Feb 13, 2018
* Fix double handling of ð (math maps to \eth, not special Unicode character)
* Remove Åå special math handling, thanks to KaTeX#1125
kevinbarabash pushed a commit that referenced this pull request Feb 14, 2018
* Fix double handling of ð (math maps to \eth, not special Unicode character)
* Remove Åå special math handling, thanks to #1125
kevinbarabash pushed a commit that referenced this pull request Feb 20, 2018
* unicodeTextInMathMode setting

* When `unicodeTextInMathMode` is `true`, accented letters from
  `unicodeSymbols.js`, and CJK and other supported languages,
  get added support in math mode (as requested in #895).
* When `unicodeTextInMathMode` is `false, all of these stop working in
  math mode, and are only supported in text mode (matching XeTeX behavior).
  Note that this is a backwards incompatibility with some 0.9.0 alpha/betas.

* Fix handling of Unicode characters ð, Å, å

* Fix double handling of ð (math maps to \eth, not special Unicode character)
* Remove Åå special math handling, thanks to #1125

* Forbid extraLatin when unicodeTextInMathMode is false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants