Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spacing functions in text mode #1139

Merged
merged 4 commits into from
Feb 4, 2018
Merged

Enable spacing functions in text mode #1139

merged 4 commits into from
Feb 4, 2018

Conversation

ronkok
Copy link
Collaborator

@ronkok ronkok commented Feb 3, 2018

Spacing functions such as \; or \quad should be accepted in either math mode or text mode. This PR will also fix a bug in \llap and \rlap and enable them to accept spacing functions.

Spacing functions such as `\;` or `\quad` should be accepted in either math mode or text mode
Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Can you add some unit tests that check that things like \llap{\,} and \rlap{\;} parse?

@ronkok
Copy link
Collaborator Author

ronkok commented Feb 4, 2018

Done.

@@ -1034,6 +1034,35 @@ describe("An overline parser", function() {
});
});

describe("An lap parser", function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we didn't have any unit test for lap. Thanks for adding these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants