Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append ApplyFunction to math functions #960

Merged
merged 6 commits into from
Nov 22, 2017
Merged

Append ApplyFunction to math functions #960

merged 6 commits into from
Nov 22, 2017

Conversation

ronkok
Copy link
Collaborator

@ronkok ronkok commented Nov 12, 2017

Copy link
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, and sorry for the delay in reviewing. LGTM, aside from one suggestion for an added comment.

@@ -69,7 +69,7 @@ defineFunction({
identifier.setAttribute("mathvariant", "normal");

const operator = new mathMLTree.MathNode("mo",
[mml.makeText("⁡", "text")]);
[mml.makeText("\u2061", "text")]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth a comment that this is <mo>&ApplyFunction;</mo> as above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@edemaine edemaine merged commit 22dd4f3 into KaTeX:master Nov 22, 2017
@edemaine
Copy link
Member

Thanks again for the PR!

@kevinbarabash
Copy link
Member

It might be nice to have an option to control the output of MathML. I like &ApplyFunction; because it's easier see what's going on, but the unicode char takes up less space which is preferable in production.

@ronkok ronkok deleted the applyfunction branch November 24, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants