Ignore hidden links for LinkText plugin - fixes #101

jdan · Oct 3, 2016 · 30dc0fd · 30dc0fd
1 parent db8746c
commit 30dc0fd
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/plugins/link-text/index.js b/plugins/link-text/index.js
@@ -68,6 +68,11 @@ class LinkTextPlugin extends Plugin {
                 return;
             }
 
+            // Ignore hidden links
+            if (axs.utils.isElementOrAncestorHidden(el)) {
+                return;
+            }
+
             // Extract the text alternatives for this element: including
             // its text content, aria-label/labelledby, and alt text for
             // images.

diff --git a/test/link-text-test.js b/test/link-text-test.js
@@ -118,4 +118,17 @@ describe("Link text plugin", function() {
         assert($("#empty-link-with-unclear-label").hasLabel());
         assert($("#empty-link-with-unclear-labelledby").hasLabel());
     });
+
+    it("should not fail on hidden links", function() {
+        document.body.innerHTML = `
+            <ul style="display:none;">
+                <li>
+                    <a id="hidden-link" href="#">About</a>
+                </li>
+            </ul>
+        `;
+
+        plugin.run();
+        assert(!$("#hidden-link").hasLabel());
+    });
 });