-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with chrome freezing on android #4
Comments
Thank you for the input. Can you please submit a pull request for the changes and I will be happy to test and implement this. Is this in regard to the browser freezing due to OOM issues if it's been running for a bit without a successful scan or some separate issue? |
I'm getting this issue as well: If I close the reader by removing the QRReader component once I get a successful scan, the browser freezes. It happens even if the reader has only been open a few seconds. |
Merged your pull request and tested, it works great. NPM Package has been updated as well. Thank you @jeznag |
This actually still seems to be an issue. Reopening this to take a closer look. |
Well, the original fix seems to work for my use case. |
Can I ask what version of Chrome you are running and on what device? I just want to compare and rule out it being a local issue. |
The issue comes and goes on a LG V60 running Chrome 89.0.4389.90 |
I actually think this might be a separate issue. I am going to close this again, that is my mistake. It seems to work, but if I refresh the page for some reason it will no longer scan. It doesn't freeze though. I have to switch to a different page with an instance of the component and it works fine, but trying to scan different codes after it's been removed from the page seems to not work. |
My test device is a Pixel 2 running Chrome 89 on Android 11 |
Fix for JodusNodus/react-qr-reader#185
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: