Name fixup is undone by replace_illegal_names
in the case of entry points
#1571
Labels
bug
Feature which should work in SPIRV-Cross does not for some reason.
in progress
Issue is being actively worked on
Currently
fixup_reserved_names
fixes names to not include invalid characters. However this fixup is undone later byreplace_illegal_names
.See the offending line: https://github.com/KhronosGroup/SPIRV-Cross/blob/master/spirv_msl.cpp#L12189
This has the side effect of also breaking structs with invalid names if a entry points returns that struct.
Possible solution is calling
fixup_reserved_names
(https://github.com/KhronosGroup/SPIRV-Cross/blob/master/spirv_msl.cpp#L1183) afterreplace_illegal_names
(https://github.com/KhronosGroup/SPIRV-Cross/blob/master/spirv_msl.cpp#L1231)Another possible solution is writing
instead of
What do y'all think? This is currently a major issue for https://github.com/EmbarkStudios/rust-gpu
The text was updated successfully, but these errors were encountered: