Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need compact-ids passes in WebGPU<->Vulkan transforms #2634

Closed
zoddicus opened this issue May 29, 2019 · 1 comment
Closed

Need compact-ids passes in WebGPU<->Vulkan transforms #2634

zoddicus opened this issue May 29, 2019 · 1 comment
Assignees
@zoddicus
Labels
api:webgpu component:optimization
Milestone
WebGPU->Vulkan Tr...

Comments

@zoddicus
Copy link
Contributor

This currently exists in the Vulkan->WebGPU, to work around an issue in SPIRV-Cross but because ids being compact isn't in the spec, the validator will not reject sparse ids, so the WebGPU->Vulkan also needs it, so that spvc can make sure ids are compact before invoking SPIRV-Cross.
@zoddicus zoddicus self-assigned this May 29, 2019
@zoddicus
Copy link
Contributor Author

Apparently I had never actually added it to either pass, so I guess my PR will do both.

@zoddicus zoddicus changed the title Add compact-ids to WebGPU->Vulkan transform Add compact-ids to WebGPU<->Vulkan transforms May 29, 2019
@zoddicus zoddicus changed the title Add compact-ids to WebGPU<->Vulkan transforms Need compact-ids passes in WebGPU<->Vulkan transforms May 29, 2019
@zoddicus zoddicus mentioned this issue May 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoddicus zoddicus

Labels
api:webgpu component:optimization
Projects
None yet
Milestone
WebGPU->Vulkan Transformation
Development

No branches or pull requests
1 participant
@zoddicus