From f56580965dd5ff4057c9e6fc2abc3391e1e69762 Mon Sep 17 00:00:00 2001 From: James Darpinian Date: Thu, 4 Apr 2019 17:16:47 -0700 Subject: [PATCH] Remove OffscreenCanvas commit() requirement (#2848) The commit() method of OffscreenCanvas contexts was controversial and has not been shipped by any browser. Rewrite the OffscreenCanvas tests to not require it. For background, see: https://github.com/w3ctag/design-reviews/issues/288 https://groups.google.com/a/chromium.org/d/topic/blink-dev/hRZ_P2o-aEk/discussion --- ...ext-attribute-preserve-drawing-buffer.html | 36 +++++++++---------- .../offscreencanvas-resize.html | 7 ++-- sdk/tests/js/tests/canvas-tests-utils.js | 1 - 3 files changed, 23 insertions(+), 21 deletions(-) diff --git a/sdk/tests/conformance/offscreencanvas/context-attribute-preserve-drawing-buffer.html b/sdk/tests/conformance/offscreencanvas/context-attribute-preserve-drawing-buffer.html index cc7fee8e9b..f00112bede 100644 --- a/sdk/tests/conformance/offscreencanvas/context-attribute-preserve-drawing-buffer.html +++ b/sdk/tests/conformance/offscreencanvas/context-attribute-preserve-drawing-buffer.html @@ -40,37 +40,37 @@ - diff --git a/sdk/tests/conformance/offscreencanvas/offscreencanvas-resize.html b/sdk/tests/conformance/offscreencanvas/offscreencanvas-resize.html index d591d3f10f..3c6906c13c 100644 --- a/sdk/tests/conformance/offscreencanvas/offscreencanvas-resize.html +++ b/sdk/tests/conformance/offscreencanvas/offscreencanvas-resize.html @@ -28,7 +28,7 @@ -Resizing Test for OffscreenCanvas +Resizing Test for OffscreenCanvas commit() @@ -39,7 +39,7 @@