Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tolerance of RGB5_A1 format when readPixels on Arm Mail GPU #3705

Open
WujianSun opened this issue Dec 18, 2024 · 1 comment · May be fixed by #3707
Open

tolerance of RGB5_A1 format when readPixels on Arm Mail GPU #3705

WujianSun opened this issue Dec 18, 2024 · 1 comment · May be fixed by #3707

Comments

@WujianSun
Copy link
Contributor

WujianSun commented Dec 18, 2024 •
edited
Loading

When we run webgl 2.0.0 cts on mali GPU G310, the case read-pixels-from-fbo-test.html fail at RGB5_A1 format.

I saw the tolerance of RGB5_A1 increased from 5 to 6
4285a36 Relax tolerance a bit to allow RGB565 RGB5_A1 RGB10_A2 format readPixels to pass
Aslo RGB565 increased from 6 to 7. Do you think we can aslo increase RGB5_A1 to 7 for Mali GPU?
Uploading 1734578816950.jpg…
WujianSun added a commit to WujianSun/WebGL that referenced this issue Dec 20, 2024
@WujianSun
Increase the error tolerance for RGB5_A1 format
33ebc37 
Mali GPU need slightly extra tolerance.

Fixes KhronosGroup#3705.

Signed-off-by: Wujian Sun <wujian.sun_1@nxp.com>
@WujianSun WujianSun linked a pull request Dec 20, 2024 that will close this issue
Open
@WujianSun
Copy link
Contributor Author

Can anyone help review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase the error tolerance for RGB5_A1 format WujianSun/WebGL
1 participant
@WujianSun