Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_lights_area: Proposal #1940

Open
maggieholbling opened this issue Jan 29, 2021 · 5 comments
Open

KHR_lights_area: Proposal #1940

maggieholbling opened this issue Jan 29, 2021 · 5 comments

Comments

@maggieholbling
Copy link

Could a rectangle type be added to the KHR_lights_punctual extension? Seeing as Unity, Unreal and Blender support rectangular area lights?

Unity: https://docs.unity3d.com/Manual/Lighting.html
Unreal: https://docs.unrealengine.com/en-US/BuildingWorlds/LightingAndShadows/LightTypes/RectLights/index.html
Blender: https://docs.blender.org/manual/en/latest/render/lights/light_object.html

If not, is there a workaround around this?

@donmccurdy
Copy link
Contributor

Related: #1475

KHR_lights_punctual is feature-complete, for the purposes of the glTF 2.0 specification, and restricted to simpler punctual lighting. But area lights could be considered as part of a future extension. Understanding which properties of area lights already have consistency across engines and authoring tools (Blender/Maya/3DS Max) might help that process, if anyone would like to research it.

@MiiBond
Copy link
Contributor

MiiBond commented Feb 2, 2021

@maggieholbling, Adobe would definitely be interested in supporting an area light extension. I'll be looking at defining one later this year, I think, as we'll have need of it. If you want to get the ball rolling by writing a draft EXT (multi-vendor) extension, I can take a peek and give feedback.

@romainguy
Copy link

@MiiBond I would love to see an area light extension as well (definitely rectangle and line lights at least).

@maggieholbling This extension would not be the right place since rectangular lights are by definition not punctual lights.

@donmccurdy donmccurdy changed the title Add rectangle light type to KHR_lights_punctual extension KHR_lights_area: Proposal Feb 24, 2021
@donmccurdy
Copy link
Contributor

I'll rename this issue as a proposal for KHR_lights_area. 👍

@donmccurdy donmccurdy linked a pull request Apr 19, 2021 that will close this issue
@UX3D-nopper
Copy link
Contributor

Could we close this and/or continue the discussion here:
#1948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants