Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search stopped returning results for System.Console and other .NET APIs #185

Closed
waf opened this issue Jun 14, 2021 · 4 comments
Closed

Search stopped returning results for System.Console and other .NET APIs #185

waf opened this issue Jun 14, 2021 · 4 comments

Comments

@waf
Copy link

waf commented Jun 14, 2021

This is specifically involving the implementation of SourceBrowser on https://source.dot.net. I hope this is the correct repository.

It appears that search results recently degraded; a week or two ago I was able to find results for System.Console, System.DateTime, etc, as well as member searches like System.Console.WriteLine. Now, none of those return results.

image

Here's the HTTP request issued by source.dot.net's front-end code (captured by Firefox's web development tools):

GET /api/symbols/?symbol=System.Console HTTP/2
Host: source.dot.net
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0
Accept: text/html
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
DNT: 1
Connection: keep-alive
Referer: https://source.dot.net/results.html
Cookie: ARRAffinity=a4803df7e3ed2a7e2d1721813ab1a3a6cb7c538cb72e82db5880cfd457148c47; ARRAffinitySameSite=a4803df7e3ed2a7e2d1721813ab1a3a6cb7c538cb72e82db5880cfd457148c47
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: same-origin
Pragma: no-cache
Cache-Control: no-cache
TE: trailers

HTTP Response:

HTTP/2 200 OK
content-type: text/html; charset=utf-8
content-encoding: gzip
vary: Accept-Encoding
server: Kestrel
request-context: appId=cid-v1:ea35bca4-09f3-4ce2-8530-160bdb9d99ec
x-ua-compatible: IE=edge
x-powered-by: ASP.NET
strict-transport-security: max-age=31536000
date: Mon, 14 Jun 2021 04:06:04 GMT
X-Firefox-Spdy: h2

<div class="note">No results found</div>
<p>Try also searching on:</p>
<ul>
</ul>

Further examples are available on the source.dot.net "overview" page -- the first couple of hyperlinks on that page don't show results.

Thanks for creating this great tool—I love it and use it often.

@KirillOsenkov
Copy link
Owner

@alexperovich

@alexperovich
Copy link
Contributor

The runtime assemblies are just... not getting indexed at all. The binlog reader isn't finding the compiler invocations somehow.... again...

@alexperovich
Copy link
Contributor

dotnet/arcade#7520 should fix things once it gets into runtime.

@alexperovich
Copy link
Contributor

This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants