-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should "pip install trame" install less packages? #133
Comments
|
They should all be fairly small. If not, I would agree with you to make things optional. |
Trame without Plotly is 30 MB, that is not that bad... |
My bad about I agree, 30MB is not that bad. But once the number of trame packages grows, this could be something we should think about. I think we agree that the goal is not to have |
Yes we will have to decide what is core (comes by default) vs what you need to declare as dependency. So far, once validated and working fine, I was bringing them inside trame by default (and leaflet should be part of it). But in general, it might be worth figuring where we draw that line and it might not be even driven by size. |
I think this is another excellent use case for pypa/setuptools#1139 If setuptools/pip could implement a "default" extra requirements, then all of the trame submodules could be in that, allowing users to opt-out for more lightweight, targeted installations. Until then, IMO, having But this brings up a different issue: while
+1. This will inevitably get messy when a community-led module gains traction that has its own heavy dependencies. I'm brainstorming a In an ideal world, that repo would have its own examples and docs, and the user could simply I want to point out the Further, IMO, the list of core trame modules should be trimmed down a bit and then we should adopt a design pattern for the rest of the trame ecosystem to explicitly list the specific, required trame packages and their necessary versions. IMO, the "core" trame modules would be:
Then modules like This would extend to hypothetical packages like |
@banesullivan what you are describing was indeed my plan for Having just Aslo since we don't want to create many breaking change, I wanted to add support for vue-3 in |
Sounds like a good plan for trame>=3.x |
As of now
pip install trame
installs the following packages:Installing
trame-client
,trame-server
makes totally sense as they are a fundamental requirement oftrame
, but maybe we can have the others in andextras_require
. Especiallytrame-vtk
is pretty hefty since it installsvtk
with >300MB.I understand that for showing the tutorials and demos it is pretty nice to have "just do
pip install trame
and it works", but maybe having a "just dopip install trame[vtk]
and it works" isn't that bad.The text was updated successfully, but these errors were encountered: