Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodash is declared as a peer dependency #99

Closed
FlorianCassayre opened this issue Jun 23, 2022 · 2 comments
Closed

lodash is declared as a peer dependency #99

FlorianCassayre opened this issue Jun 23, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@FlorianCassayre
Copy link

The installation documentation of e.g. the typedoc-plugin-pages package says:

npm install --save-dev @knodes/typedoc-plugin-pages typedoc@^0.22.0

However this is not sufficient since lodash is declared as a peer dependency. This means that if a project does not have lodash installed, the plugin will crash.

I am also questioning the motivation behind having lodash as a peer dependency, especially for a server-side only module.

In any case, thanks for the great plugins.

@GerkinDev
Copy link
Member

Indeed. I'm working on a new iteration, during which I'll fix this. Thank you

@GerkinDev GerkinDev added the bug Something isn't working label Jun 23, 2022
@FlorianCassayre
Copy link
Author

Excellent, thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants