Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not allow for optimizations for WASM targets #42

Closed
GeeWee opened this issue Dec 22, 2023 · 2 comments
Closed

Does not allow for optimizations for WASM targets #42

GeeWee opened this issue Dec 22, 2023 · 2 comments

Comments

@GeeWee
Copy link

GeeWee commented Dec 22, 2023

I have a WASM server-side project I'd love to try out PGO on. Unfortunately it does not seem to work. E.g. running the command

cargo pgo instrument build -- --bin my-binary--release --target wasm32-wasi

results in the error

error[E0463]: can't find crate for `profiler_builtins`

however, the same command without the --target does not provoke the same error.

I do not necessarily think this is anything cargo-pgo can do anything about - I believe the underlying issue is this one. I figured I'd create an issue anyways, in case I was wrong, or anyone else came looking for the same information.

@Kobzol
Copy link
Owner

Kobzol commented Dec 23, 2023

Yeah, this is not related to this crate. That error simply means that this specific target is not distributed with support for PGO. Either because this target doesn't support it, or simply because we just don't build and ship it on CI via rustup.

@GeeWee
Copy link
Author

GeeWee commented Jan 3, 2024

That makes sense. Feel free to close, but just wanted to point this out if someone else came searching for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants