device_support(Iluminize): add RGBWW Lighting model to 511.050
#7369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Apr 8, 2024
src/devices/iluminize.ts
Outdated
| @@ -24,7 +24,7 @@ const definitions: Definition[] = [ | |||
| extend: [onOff()], | |||
| }, | |||
| { | |||
| zigbeeModel: ['511.050'], | |||
| zigbeeModel: ['511.050', 'RGBWW Lighting'], | |||
There was a problem hiding this comment.
The model is quite generic, can you use a fingerprint with manufacturerName + modelId instead?
There was a problem hiding this comment.
Seems the converters for that manufacturer need sprucing up in general.
There was a problem hiding this comment.
@Koenkk this seems wrong. The vendor is iluminize or Sunricher the Modell is the same: 511.050
There was a problem hiding this comment.
Converted all of those to fingerprints too for good measure
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @derkorte for pointing this model out as unsupported.