fix: STARKVIND child_lock was broken after refactor #7602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported here Koenkk/zigbee2mqtt#8744 (comment), this refactor inverted the logic for child_lock and also changed the type to boolean true/false while most child_lock exposes use LOCK/UNLOCK. This change addresses reverts back to the old behavior.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported here Koenkk/zigbee2mqtt#8744 (comment), the refactor to modernExtend inverted the logic for child_lock and also changed the type to boolean true/false while most child_lock exposes use LOCK/UNLOCK.
This change addresses this, by reverting back to the old behavior and LOCK/UNLOCK value.
Testing was easy, I observe the wrong and inverted behavior on my STARKVIND. And observed the correct behavior afterwards.