Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hilux Dimmer-Switch-ZB3.0 #7763

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

bjornbak
Copy link
Contributor

@bjornbak bjornbak commented Jul 13, 2024

Same DIN Dimmer Switch https://www.ledproff.dk/zigbee-produkter/21936-hilux-zigbee-din-skinne-lysdaemper-250w-5714255007350.html sold under multiple Vendor names.

Previous batches I bought of it was recognized as Candeo HK-DIM-A but the latest was unsupported until I added it as Vendor Hilux too.

@@ -9,6 +9,13 @@ const definitions: Definition[] = [
description: 'Spot 7W',
extend: [light({colorTemp: {range: [153, 370]}, powerOnBehavior: false})],
},
{
zigbeeModel: ['Dimmer-Switch-ZB3.0'],
model: 'Dimmer-Switch-ZB3.0',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this with the actual model number written on the device?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it is installed by a certified electrician a while back and just didn't get around to fix in z2m before now.

I can't see any model number 😭
20240713_104708

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything written on the site of this product?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the pictures here: https://ledpaerer.dk/zigbee-din-rail-dimmer.html?gad_source=1&gclid=CjwKCAjwy8i0BhAkEiwAdFaeGDe8224f_XdUwuEM_axNunYCiFmEvnXcBzuXeaY28oevcG6o5JkiVRoCxGUQAvD_BwE

I can't see check now that it is installed. I remember the diagram but don't remember if anything was written on the opposite side or the back.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the site I see D160-ZG

@@ -9,6 +9,13 @@ const definitions: Definition[] = [
description: 'Spot 7W',
extend: [light({colorTemp: {range: [153, 370]}, powerOnBehavior: false})],
},
{
zigbeeModel: ['Dimmer-Switch-ZB3.0'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide the data/database.db of this device? There are multiple devices which use the model ID so we should use a fingerprint here (example: https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/candeo.ts#L13)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 19e83eb what you are asking for?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can you also try if it works after removing zigbeeModel: ['Dimmer-Switch-ZB3.0'],?

Copy link
Contributor Author

@bjornbak bjornbak Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure we are on the same page.
What I am testing is

external_converters:
  - hilux.js

in configuration.yaml

hilux.js:

const {light} = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
    fingerprint: [{modelID: 'Dimmer-Switch-ZB3.0', manufacturerName: 'Hilux'}],
    model: 'Dimmer-Switch-ZB3.0',
    vendor: 'Hilux',
    description: 'Zigbee LED dimmer smart switch',
    extend: [light({configureReporting: true})],
};

module.exports = definition;

Restart Z2M to see that is working and then I do the same to this PR?

If so, done that now :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@bjornbak bjornbak requested a review from Koenkk July 16, 2024 04:31
@Koenkk Koenkk merged commit 5fd150e into Koenkk:master Jul 16, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jul 16, 2024

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

@bjornbak bjornbak deleted the add_hilux_dimmer_switch_zb3.0 branch July 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants