Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZDO spec: improve build/read logic and typing. #1186

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Sep 14, 2024

In preparation for ZDO removal from adapters:

  • Fixup consts usage from spec and some typos
  • No longer throw when reading response status !== 0, status is returned as tuple [status, payload | undefined]
  • Add buildRequest with auto param typing based on clusterId to match readResponse usage pattern
  • Add typing for readResponse based on clusterId
  • Add checkStatus static util to type result of readResponse based on status
  • Improve tests

NOTE: Some adjacent stuff also needs improving, but better to wait for next PR, since some of it is going to change/disappear completely.

@Koenkk Koenkk merged commit c8cb557 into Koenkk:master Sep 14, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Sep 14, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants