mdns discovery fix. adapter always zstack #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
checking for auto makes no sense because in this case the hasOwnProperty(serialPortOptions.adapter) check will still fail. |
|
I apologize for the push spam, but only the test script works on Windows. All the others don't work, probably due to file path issues, in any case I couldn't get them to run even after trying to fix the paths |
Koenkk
reviewed
Sep 16, 2023
src/adapter/adapter.ts
Outdated
| resolve(new adapter(networkOptions, serialPortOptions, backupPath, adapterOptions, logger)); | ||
|
|
||
| if (adapterLookup.hasOwnProperty(serialPortOptions.adapter) | ||
| && serialPortOptions.adapter !== 'auto') { |
There was a problem hiding this comment.
adapterLookup doesn't contain auto so the serialPortOptions.adapter !== 'auto' statement is not needed
There was a problem hiding this comment.
I understand that, but typescript doesn't
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mdns discovery only worked with zstack adapters. This PR fixes this bug and the adapter will be taken from the mdns configuration