Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl UriMeta, add meta info and status in tx history #1823

Merged
merged 20 commits into from
May 25, 2023
Merged

Impl UriMeta, add meta info and status in tx history #1823

merged 20 commits into from
May 25, 2023

Conversation

laruh
Copy link
Member

@laruh laruh commented May 12, 2023 •
edited
Loading

#900
This pr contains the following enhancements:

  • struct UriMeta was added. it covers the necessary info about token: image, token_name, description, attributes. animation_url
  • collection_name was added in NftTransferHistory
  • transfer status Receive or Send

@laruh laruh requested a review from onur-ozkan May 12, 2023 14:14
@laruh laruh added 1.0.5-beta in progress Changes will be made from the author and removed under review labels May 12, 2023
@laruh laruh added under review in progress Changes will be made from the author and removed in progress Changes will be made from the author under review labels May 16, 2023
laruh added 2 commits May 18, 2023 13:28
@laruh
Merge remote-tracking branch 'origin/dev' into add-token-uri-info-to-…
5c84391 
…nft-struct

# Conflicts:
#	mm2src/coins/nft.rs
#	mm2src/coins/nft/nft_structs.rs
#	mm2src/coins/nft/nft_tests.rs
@laruh
display Chain in uppercase
f2a40d2
@laruh laruh added under review and removed in progress Changes will be made from the author labels May 18, 2023
onur-ozkan
onur-ozkan requested changes May 18, 2023
View reviewed changes
mm2src/coins/nft.rs Outdated Show resolved Hide resolved
mm2src/coins/nft.rs Outdated Show resolved Hide resolved
@laruh laruh added in progress Changes will be made from the author and removed under review labels May 22, 2023
@laruh laruh changed the title Impl UriMeta to get info from token uri, collection name in nft transfer history, transfer status Impl UriMeta, add meta info and status in tx history May 23, 2023
@laruh laruh added under review and removed in progress Changes will be made from the author labels May 23, 2023
onur-ozkan
onur-ozkan previously approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fixes!

@laruh laruh requested a review from shamardy May 25, 2023 08:33
shamardy
shamardy approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shamardy shamardy merged commit 1e2ec29 into dev May 25, 2023
@onur-ozkan onur-ozkan deleted the add-token-uri-info-to-nft-struct branch May 29, 2023 06:48
@shamardy shamardy mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@onur-ozkan onur-ozkan onur-ozkan left review comments

Assignees
No one assigned
Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laruh @shamardy @onur-ozkan